Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected call to parse_endtag #18

Closed
arcane99 opened this issue Nov 1, 2019 · 4 comments
Closed

unexpected call to parse_endtag #18

arcane99 opened this issue Nov 1, 2019 · 4 comments
Labels

Comments

@arcane99
Copy link

arcane99 commented Nov 1, 2019

Hi. Getting a sporadic error 'unexpected call to parse_endtag". I haven't been able to replicate the issue reliably.

Occurs here in parse.py file in htmlmin.
assert rawdata[i:i+2] == "</", "unexpected call to parse_endtag"

However as a suggestion, perhaps a try except AssertionError should be added to the reponse_minify method. This way even if the error does occur, the final webpage is still rendered as the original unminified response is returned.

@hamidfzm
Copy link
Owner

hamidfzm commented Nov 1, 2019 via email

@arcane99
Copy link
Author

arcane99 commented Nov 1, 2019

Hi Hamid, created the Pull Request. Fairly small change made, hope it is okay.

@stale
Copy link

stale bot commented Dec 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 1, 2019
@stale
Copy link

stale bot commented Dec 4, 2019

Closed due to inactivity, feel free to open another issue if the problem persists.

@stale stale bot closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants