Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove objc_sync_enter/objc_sync_exit #22

Closed
hamin opened this issue Oct 2, 2016 · 5 comments
Closed

Remove objc_sync_enter/objc_sync_exit #22

hamin opened this issue Oct 2, 2016 · 5 comments

Comments

@hamin
Copy link
Owner

hamin commented Oct 2, 2016

I think we should just be able to use dispatch lock queues here like so:

let lockQueue = dispatch_queue_create("com.test.LockQueue", nil)
dispatch_sync(lockQueue) {
    // code
}

/cc @shams-ahmed

@shams-ahmed
Copy link
Contributor

@hamin I agree only used objc_sync_enter due to its easy of use. ones the projects moved to swift 3 dispatch queue should be the way forward

@fengshi92
Copy link
Contributor

May I ask when will this issue be addressed? It sometimes causes my urlSession delegate queue deadlock. Looking forward to hear from you!

@hamin
Copy link
Owner Author

hamin commented May 31, 2017

@fengshi92 i haven't had a chance to look at this yet. Do you wanna take a shot at it and submit a PR? Since you're experiencing a deadlock issue right now your input would be super valuable

@fengshi92
Copy link
Contributor

Due to legal reason of my company, I can't submit a pull request right now. Maybe later I could submit a fix. However I just want to let you know that the proposed method above resolved my problem. Thanks!

@hamin
Copy link
Owner Author

hamin commented Jul 26, 2017

fixed by #27

@hamin hamin closed this as completed Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants