Adding force delete to erb2haml #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syguer
reviewed
Oct 30, 2017
lib/tasks/erb2haml.rake
Outdated
| @@ -59,7 +59,7 @@ namespace :haml do | |||
| puts '-'*80 | |||
| begin | |||
| puts 'Would you like to delete the original .erb files? (This is not recommended unless you are under version control.) (y/n)' | |||
| should_delete = STDIN.gets.chomp.downcase[0] | |||
| should_delete = ENV["FORCE_ORIGINAL_ERB_DELETE"] ? "y" : STDIN.gets.chomp.downcase[0] | |||
There was a problem hiding this comment.
This name (FORCE_ORIGINAL_ERB_DELETE ) looks easy to conflict for me.
But adding prefix ( such as HAML_RAILS_) is too long...
There was a problem hiding this comment.
Cool, at work just now, i'll think about the variable name and add to the readme shortly.
There was a problem hiding this comment.
actually, just thinking about it, there is a use case to do the opposite too, to force to NOT delete the erb also, but still not ask the question. I'll refactor for this too.
|
Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #132