Temple migration #860
Merged
Temple migration #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/haml/temple_engine.rb
Outdated
| module Haml | ||
| class TempleEngine < Temple::Engine | ||
| define_options( | ||
| :attr_wrapper => "'", |
There was a problem hiding this comment.
We can use 1.9 hash syntax since Haml requires ruby 1.9.
|
On first glance, this looks great to me. 👏 👏 👏 |
|
Thanks ! FYI, without it, I had terrible performance issues with Jruby 9.1.2.0. |
|
Very excited to see this happening. Thanks @k0kubun for your fantastic work over the last few years on everything related to Haml! |
k0kubun
added a commit
that referenced
this pull request
Feb 6, 2017
k0kubun
added a commit
to k0kubun/hamlit
that referenced
this pull request
May 27, 2017
I changed Haml to use Temple. haml/haml#860 haml/haml#893 haml/haml#904 Hamlit is still faster than Haml for C extension and absence of Haml::Buffer, which is required for Haml helpers.
michaelzedwards
added a commit
to michaelzedwards/hamlit
that referenced
this pull request
Feb 11, 2022
I changed Haml to use Temple. haml/haml#860 haml/haml#893 haml/haml#904 Hamlit is still faster than Haml for C extension and absence of Haml::Buffer, which is required for Haml helpers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #851
I migrated Haml's engine backend to Temple.
In this PR, I didn't change compiler process to temple-AST-based one and make breaking changes. But now
Haml::ParserandHaml::Compilerare on Temple Engine's pipeline.There is no feature addition or performance improvement but refactoring for future maintainability.
Since I implemented Hamlit v2 with original
Haml::Parserin k0kubun/hamlit#43, I know we can compileHaml::Parser::ParseNodeinto Temple AST (but not completely compatible aboutHaml::Helpers, though). This is just a first step for a whole migration.