Fix compiler to work without deprecation on ruby 2.4 #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forwardable in ruby 2.4 prints a deprecation warning if forwarding to a private method (preview2 actually raises an exception). Haml::Engine forwards precompiled_method_return_value to Haml::Compiler, so the easiest way to fix this is to make Haml::Compiler#precompiled_method_return_value public.
|
@jeremyevans Yes, I'm also seeing this on my apps. Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwardable in ruby 2.4 prints a deprecation warning if forwarding
to a private method (preview2 actually raises an exception).
Haml::Engine forwards precompiled_method_return_value to
Haml::Compiler, so the easiest way to fix this is to make
Haml::Compiler#precompiled_method_return_value public.