Don't preserve newlines in attributes #903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haml::Helpers.preserve
is very slow. I don't think it's necessary for attributes because Slim, Faml and Hamlit don't preserve them and work fine.The original change was done in 2008 e8075e7 and no reason is found to keep that change. Let's remove a legacy feature.
Benchmark
With Ruby 2.4.0 and k0kubun/haml_bench/templates/slim_bench.haml,
before
after
@haml/committers WDYT?