Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filetransfer service #108

Merged
merged 3 commits into from Aug 15, 2020
Merged

Conversation

roleyfoley
Copy link
Contributor

@roleyfoley roleyfoley commented Aug 10, 2020

Description

AWS implementation of hamlet-io/engine#1369

Adds the following

  • Services for the AWS Transfer family ( https://aws.amazon.com/aws-transfer-family/ )
  • Component for file transfer based on the AWS Transfer family
  • Public Key support for the user component - allowing for multiple public keys to be configured for a user
  • Public and private support for SFTP gateway using EIP's and Security groups

Motivation and Context

To Support file transfer integration with services that do not support cloud provider integration

How Has This Been Tested?

Tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves the structure or operation of the implementation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Followup Actions

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • [X ] None of the above.

Copy link
Contributor

@ml019 ml019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall structure looks in pattern. As this will be tested with customer site shortly, will merge on basis of quick turnaround/detection for any bugs,

@ml019 ml019 merged commit 5d8d506 into hamlet-io:master Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants