Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filetransfer): security group management for filetransfer #76

Merged
merged 1 commit into from
Aug 15, 2020

Conversation

roleyfoley
Copy link
Contributor

@roleyfoley roleyfoley commented Aug 10, 2020

Description

Adds a utility function to assign an appropriate security group to the filetransfer VPC Endpoint

Motivation and Context

Currently when the AWS Transfer VPC Endpoint is provisioned it defaults to using the default VPC Security group which doesn't allow inbound access to the service and can't be managed from Cloud formation. This utility swaps the default security group for a security group created by hamlet during the template deployment process

How Has This Been Tested?

Tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves the structure or operation of the implementation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Followup Actions

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • None of the above.

@roleyfoley roleyfoley requested a review from a team August 10, 2020 05:16
@ml019 ml019 changed the title feat(filetranfer): security group management for filetransfer feat(filetransfer): security group management for filetransfer Aug 15, 2020
@ml019 ml019 merged commit ac7b178 into master Aug 15, 2020
@roleyfoley roleyfoley deleted the filetransfer-support branch August 21, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants