Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate web from worker metrics and add 2 more #2

Merged
merged 4 commits into from Apr 29, 2020

Conversation

hammady
Copy link
Owner

@hammady hammady commented Apr 28, 2020

  • This separates Prometheus metrics into web and worker metrics
  • For web, it adds response time metric
  • For worker, it adds queue size metric
  • It also fixes an issue where the Prometheus instance label was not unique, and typically it should match the instance unique identifier (e.g. hostname).

@hammady hammady requested a review from fabubaker April 28, 2020 22:30
@coveralls
Copy link

coveralls commented Apr 29, 2020

Coverage Status

Coverage decreased (-1.5%) to 73.919% when pulling 64f1dcf on queue-size-reporting into 3d13dd9 on master.

@hammady hammady merged commit bdc6462 into master Apr 29, 2020
@hammady hammady deleted the queue-size-reporting branch April 29, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants