Fixes bool filters, add new bool filters, and add createdAt and updatedAt to get_transactions #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hammem
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Thanks, @CalvinChanCan , for finding the bug and fixing it.
One small copypasta error I noted, but great otherwise.
monarchmoney/monarchmoney.py
Outdated
| variables["filters"]["isSplit"] = is_split | ||
|
|
||
| if imported_from_mint is not None: | ||
| variables["filters"]["importedFromMint"] = is_split |
There was a problem hiding this comment.
Looks like this should be 'imported_from_mint'
There was a problem hiding this comment.
Ah thanks for catching that! Just fixed it.
grablair
approved these changes
Nov 21, 2023
Closed
|
Will fix #46 |
|
Thanks all! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Fixes Bool Filter Default Behavior
False, resulting in unintended filter application. The fix ensures that if bool filters are not provided, the filter is not applied.Introduces Two New Bool Filters
imported_from_mintandsynced_from_institution, providing more detail in filtering transactions based on their import source.Transaction Response Enhancements
createdAtandupdatedAtfields in the transaction response.Please let me know if there's anything I should change or any feedback. Thanks!