Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptiType does not use razerS3 to filter to HLA reads prior to running #423

Closed
tavinathanson opened this issue Feb 13, 2017 · 6 comments
Closed

Comments

@tavinathanson
Copy link
Member

Per the README, and sounds like @rleonid has always done this:

Optional step zero: you might want to filter your sequencing data for HLA reads. Should you have to re-run OptiType multiple times on the same sample (different settings, etc.) it could save you time if instead of giving OptiType the full, multi-gigabyte sequencing data multiple times, you would rather give it the relevant reads only, on the order of megabytes.

Razers3 is called internally in https://github.com/FRED-2/OptiType/blob/master/OptiTypePipeline.py but that appears to not be doing the same thing (note -m 99999, for example).

@tavinathanson
Copy link
Member Author

Re whether this could impact the results, from @rleonid:

Results: (AFAIK) theoretically, no. But practically, I wouldn’t be surprised if numerically there are some issues.

@rleonid
Copy link
Member

rleonid commented Feb 13, 2017

I'd like to recluse myself from being the judge/authority on constraint solvers. I've implemented toy simplex solvers but I don't know what kind of heuristics modern solvers might use.

@tavinathanson
Copy link
Member Author

Possible, but seems unlikely to me, that this could address the memory issues in #419.

@tavinathanson
Copy link
Member Author

@ihodes I'll try the pre-filtering manually on 30GB RAM and see what happens.

@tavinathanson
Copy link
Member Author

Discussed offline: pre-filtering manually with 30GB of RAM also ran out of memory.

@ihodes
Copy link
Member

ihodes commented Feb 14, 2017

Closing for #426

@ihodes ihodes closed this as completed Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants