Getting rid of memoization on many properties and methods #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,7 +55,7 @@ def __init__(self, gtf_path, cache_directory_path=None): | |||
|
|
|||
| def __eq__(self, other): | |||
| return ( | |||
| isinstance(other, GTF) and | |||
| (other.__class__ == GTF) and | |||
There was a problem hiding this comment.
not important, but just noting I think this change means you can't subclass GTF and have equality work. Not sure if that's intentional
There was a problem hiding this comment.
Hard to imagine when we'd want a sub-class of GTF to equal to a GTF instance, seemed safer to restrict equality to exactly the same class. .
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses: #150
We're still leaking an unbounded amount of memory to memoization but now it's at least being centralized through a few "important" methods such as those which get Gene, Transcript, and Exon objects by ID or the database query helpers.
This change is