Override cache dir if PYENSEMBL_CACHE_DIR is set #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -111,8 +112,12 @@ def __init__( | |||
| annotation_name=annotation_name, | |||
| annotation_version=annotation_version) | |||
|
|
|||
| self._cache_directory_path = datacache.get_data_dir( | |||
| subdir=self.cache_subdirectory) | |||
| if environ.get(ENV_KEY) is None: | |||
There was a problem hiding this comment.
Isn't the if handled by datacache?
https://github.com/hammerlab/datacache/blob/master/datacache/common.py#L29-L33
There was a problem hiding this comment.
Correct — but I wanted to make this more explicit as it is not apparent from the function call what will happen if you pass both variables.
Actually, maybe adding a comment there to explain this might be better. Let me do that 👍
armish
force-pushed
the
custom-cache-dir
branch
2 times, most recently
from
2847d76
to
df22255
Compare
| self._cache_directory_path = datacache.get_data_dir( | ||
| subdir=self.cache_subdirectory) | ||
| subdir=self.cache_subdirectory, |
|
LGTM! |
| from os.path import join, exists, split, abspath | ||
| from shutil import copy2, rmtree | ||
| import logging | ||
|
|
||
| import datacache | ||
|
|
||
| CACHE_BASE_SUBDIR = "pyensembl" | ||
| ENV_KEY = "PYENSEMBL_CACHE_DIR" |
There was a problem hiding this comment.
nit: might call this something a bit clearer and non-abbreviated like CACHE_DIRECTORY_ENVIRONMENT_VARIABLE
|
thanks all! Addressed your comments in my amended commit. Will merge and release on 💚 |
|
Fixes #145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that we can write the cache to a shared directory when running analyses on multi-node clusters.
Context: hammerlab/biokepi#268
cc: @arahuja and @seb
This change is