Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got rid of biotypes.py #165

Merged
merged 4 commits into from
Sep 16, 2016
Merged

Got rid of biotypes.py #165

merged 4 commits into from
Sep 16, 2016

Conversation

iskandr
Copy link
Contributor

@iskandr iskandr commented Sep 16, 2016

Biotypes are now just strings whose validity is no longer checked. Trying to keep up with additions to the set of Ensembl biotypes was a nightmare.

Other changes:

  • Changed Transcript.id -> Transcript.transcript_id, Transcript.name -> Transcript.transcript_name and made equivalent changes for Gene. For backward compatibility added id and name properties to Gene and Transcript.
  • Added biotype as an argument to LocusWithGenome.
  • Added is_protein_coding property to LocusWithGenome.

This change is Reviewable

@iskandr
Copy link
Contributor Author

iskandr commented Sep 16, 2016

Closes #155

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 81.392% when pulling 46b5cb2 on goodbye-biotype-checking into 6fbf8ad on master.

@coveralls
Copy link

coveralls commented Sep 16, 2016

Coverage Status

Coverage decreased (-0.1%) to 81.392% when pulling 46b5cb2 on goodbye-biotype-checking into 6fbf8ad on master.

@coveralls
Copy link

coveralls commented Sep 16, 2016

Coverage Status

Coverage decreased (-0.1%) to 81.392% when pulling 87fa186 on goodbye-biotype-checking into 6fbf8ad on master.

@iskandr
Copy link
Contributor Author

iskandr commented Sep 16, 2016

@timodonnell called this "astoundingly amazing" and "excellent".

@iskandr iskandr merged commit 2b83f78 into master Sep 16, 2016
@iskandr iskandr deleted the goodbye-biotype-checking branch September 16, 2016 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants