Add support for since, take 2 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ------- hamnis#13 added `since` attribute, but it did not implement the `def apply` generation based on the version combinations of the since values. Solution -------- This implements the `apply` generation. 1. `apply` with all fields are generated. 2. Next a set of since values are calculated, including lack of `since`, and additive since increments are generated. For example, given none, 1.0, and 1.1, there will be (none), (none, 1.0), and (full). `apply`s are generated for (none) and (none, 1.0). Newer since fields must have a default value. 3. `apply` without default values are generated if since combination hasn't created it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#13 added
sinceattribute, but it did not implement the
def applygeneration based onthe version combinations of the since values.
Solution
This implements the
applygeneration.applywith all fields are generated.since,and additive since increments are generated. For example, given
none, 1.0, and 1.1, there will be (none), (none, 1.0), and (full).
applys are generated for (none) and (none, 1.0).Newer since fields must have a default value.
applywithout default values are generated if since combinationhasn't created it.