Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change to hatch project management #11

Merged
merged 1 commit into from
May 12, 2023

Conversation

jimisola
Copy link
Contributor

@jimisola jimisola commented May 11, 2023

Updated project to use hatch project management instead of setup-tools etc.

Next step (PR #12) will be to provide a GitHub Action for build and publishing.

Please check all the information in pyproject.toml and update accordingly (e.g. version = 0.3.0, python versions etc).

NOTE: Not fully tested yet. Need testing from others as well.

  • I experienced so issues will trying to install tarball using pip install locally. Not sure if it should work or if there is a problem on my computer or if would work when installing from pypi.org.

  • Installing whl file with pip install works.

  • The client script is as maven-artifact not to cause conflict with other software (as described here

Relates: #10

@jimisola jimisola force-pushed the feature/convert_to_pyproject.yaml branch from dfad8c7 to 91e924d Compare May 11, 2023 23:53
@jimisola jimisola force-pushed the feature/convert_to_pyproject.yaml branch from 91e924d to 10df7a3 Compare May 12, 2023 00:14
@hamnis
Copy link
Owner

hamnis commented May 12, 2023

I am not a python developer, so this is the first time I have seen hatch.

Did you change the package name now since you move the source to src/maven_artifact, or is this just some convention root source directory which is the same as the package name?

There are no tests here and the formatting is bespoke ( Whatever I felt like ).

The missing tests are because I couldnt be bothered to figure out how that worked since I wrote this for myself.
Any tests added are appreciated.

@jimisola
Copy link
Contributor Author

Hi 🇳🇴 from 🇸🇪

I am not a python developer, so this is the first time I have seen hatch.

I've only done python scripts before but are working on two different python tools at work now, so I've had to dive in lately. Python is Python, there are so many ways and tools to do things - including with builds. hatch is apparently the way to go. It works well for us. That said, I'm no python guru.

Did you change the package name now since you move the source to src/maven_artifact, or is this just some convention root source directory which is the same as the package name?

pypi package: maven_artifact (used with pip install)
python package: maven_artifact (used when importing)

So, I changed from maven to maven_artifact since it "made more sense" to not have different names for pip and python.

There are no tests here and the formatting is bespoke ( Whatever I felt like ).

Ok. I can add support for black and flake8 (standard PEP) and there is support in IDEs as well.

The missing tests are because I couldnt be bothered to figure out how that worked since I wrote this for myself. Any tests added are appreciated.

I can add a test and then others can continue.

Might be able to have a look at it during the weekend.

But, I need to know that you'll accept the PR(s) otherwise I spend my time on something else ;)

@hamnis
Copy link
Owner

hamnis commented May 12, 2023

Sounds good. Lets move forward with this.

All PRs are welcome :)

@hamnis hamnis merged commit 900d12e into hamnis:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants