Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins should be isolated from the factory and protocols #7

Open
MostAwesomeDude opened this issue May 26, 2013 · 1 comment
Open

Plugins should be isolated from the factory and protocols #7

MostAwesomeDude opened this issue May 26, 2013 · 1 comment
Labels
core

Comments

@MostAwesomeDude
Copy link
Contributor

The main goal here is to enable CLI functional testing of plugins, and in order for this to work, Hamper needs to be able to manipulate plugins without necessarily starting up an IRC client.

Work is already underway; this is just a tracking bug.
MostAwesomeDude added a commit to MostAwesomeDude/hamper that referenced this issue May 26, 2013
@MostAwesomeDude
commander: Isolate plugin loading.
36a44bd 
Refs hamperbot#7.
MostAwesomeDude added a commit to MostAwesomeDude/hamper that referenced this issue May 26, 2013
@MostAwesomeDude
plugins: Look for loader.
1eab708 
This kind of "iterate over the plugins" could probably be factored.

Refs hamperbot#7.
MostAwesomeDude added a commit to MostAwesomeDude/hamper that referenced this issue May 26, 2013
@MostAwesomeDude
commander, plugins/quote: Isolate database configuration.
689d19e 
Not sure if this works for quotes, since that plugin appears to not register
commands correctly. What is up with that?

Refs hamperbot#7.
MostAwesomeDude added a commit to MostAwesomeDude/hamper that referenced this issue May 26, 2013
@MostAwesomeDude
commander: Remove plugin add/remove from the IRC client.
58da029 
And update the plugin plugins to match.

...At some point, "plugin" starts to look like a very funny word.

Refs hamperbot#7.
MostAwesomeDude added a commit to MostAwesomeDude/hamper that referenced this issue May 26, 2013
@MostAwesomeDude
commander: Isolate plugin running.
68d39bf 
At this point, we've pulled everything out. All that remains is to unknot some
of the execution.

Refs hamperbot#7.
@MostAwesomeDude MostAwesomeDude mentioned this issue May 26, 2013
Merged
MostAwesomeDude added a commit to MostAwesomeDude/hamper that referenced this issue May 26, 2013
@MostAwesomeDude
commander, plugins/bitly: Pass in configuration on plugin loader.
2cf329d 
Remember, kids, don't code while tired.

Refs hamperbot#7.
MostAwesomeDude added a commit to MostAwesomeDude/hamper that referenced this issue May 26, 2013
@MostAwesomeDude
commander: Remove CommanderFactory.registerPlugin().
3236e5c 
And fix its only use.

Refs hamperbot#7.
@justinnoah
Copy link
Member

@MostAwesomeDude I see that PluginLoader has been merged, does that solve this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MostAwesomeDude @justinnoah