Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CJS #2

Merged
merged 1 commit into from
May 2, 2024
Merged

Support CJS #2

merged 1 commit into from
May 2, 2024

Conversation

honeymaro
Copy link
Contributor

Hi there, this is Maro.
I'm delighted to have come across your project and I think it's great.

I do have a suggestion though, which is to include CJS build.
The reason is that some frameworks, like Nestjs, do not support ESM.

So, I simply added the cjs format in your build configuration and it worked perfectly.
Thank you!

@hampuskraft hampuskraft merged commit 858e9da into hampuskraft:main May 2, 2024
@hampuskraft
Copy link
Owner

Thanks @honeymaro — this is now released in v1.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants