Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby-hamster now packaged for Debian / request: please add license to gem file #221

Closed
hzulla opened this issue Jan 26, 2016 · 15 comments
Closed
Assignees

Comments

@hzulla
Copy link

hzulla commented Jan 26, 2016

Hi there,

ruby-hamster is being used by Sonic Pi to teach coding to kids. In an effort to bring Sonic Pi to Debian, the hamster gem has now been packaged: ruby-hamster at Debian.

While packaging, one issue turned up - what is the correct license for this gem, since there is no license file in the gem download package?

For unknown reasons, the license file is present in the github repo, but not in the gem file. To make packaging and distribution easier, please consider adding the license file to the gem download. Thanks!

@alexdowad
Copy link
Contributor

@hzulla Thanks for your interest in Hamster. I have adjusted the gemspec to include the license file in the gem.

@krainboltgreene New minor version?

@krainboltgreene
Copy link
Member

👍

@krainboltgreene krainboltgreene self-assigned this Jan 26, 2016
@alexdowad
Copy link
Contributor

@krainboltgreene There is a funny build failure whereby Travis CI can't install the Hamster gem on certain Ruby versions. I am looking at it.

@krainboltgreene
Copy link
Member

Weeeeeee. Thanks for checking on it.

@alexdowad
Copy link
Contributor

Looks like Travis CI is using an old version of Bundler. From their output:

$ bundle --version
Bundler version 1.8.4

On my PC:

21:42 ~prog/Ruby/parser % rbenv shell 2.3.0
21:42 ~prog/Ruby/parser % bundle --version
Bundler version 1.11.2

In this thread, one of the Bundler devs stated that he thinks this bug should be fixed by a commit which made it into v1.11.2.

@hzulla
Copy link
Author

hzulla commented Jan 27, 2016

Thanks!

A new release would be helpful, as the current version 2.0.0 doesn't work with ruby-concurrent 1.0.0 and needed to be patched for Debian.

@alexdowad
Copy link
Contributor

@hzulla Why not just submit a PR rather than patching the code downstream?

@hzulla
Copy link
Author

hzulla commented Jan 27, 2016

@alexdowad the patch for Debian was taken from your current development version.

@Ch4s3 patched this already here. You just didn't do a release of the gem since then.

@alexdowad
Copy link
Contributor

@krainboltgreene Can you go ahead and cut a new minor release? It looks like the Travis CI failure is a problem on their side.

@hzulla
Copy link
Author

hzulla commented Feb 20, 2016

So, new release coming?

@alexdowad
Copy link
Contributor

@krainboltgreene New gem please!

@krainboltgreene
Copy link
Member

Out!

@krainboltgreene
Copy link
Member

@alexdowad It was a major release, actually, since we changed the behavior of values_at.

@Ch4s3
Copy link
Contributor

Ch4s3 commented Feb 22, 2016

Awesome! @hzulla I'm excited to see that the new version is used on Sonic Pi!

@samaaron
Copy link

Hamster is wicked. Thanks so much for creating it. Immutability is such an important thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants