Prevent bin/stalk from polluting Object with Stalker methods #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling 'include Stalker' in the context of main (which is an instance of Object) also extends Object with the class/instance methods from Stalker, which basically pollutes all objects in an application. Here is a gist which demonstrates the behaviour: https://gist.github.com/2231315 And this ticket which is probably related: adamwiggins#14 Calling 'extend Stalker' works on the instance of the current object. When used in the context of main, all the methods from Stalker are loaded and the global Object isn't polluted.
han
added a commit
that referenced
this pull request
Mar 29, 2012
Prevent bin/stalk from polluting Object with Stalker methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling 'include Stalker' in the context of main (which is an instance
of Object) also extends Object with the class/instance methods from
Stalker, which basically pollutes all objects in an application.
Here is a gist which demonstrates the behaviour:
https://gist.github.com/2231315
And this ticket which is probably related:
adamwiggins#14
Calling 'extend Stalker' works on the instance of the current object.
When used in the context of main, all the methods from Stalker are
loaded and the global Object isn't polluted.