Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap SassC/Sass gems #108

Merged
merged 6 commits into from Sep 13, 2019
Merged

Wrap SassC/Sass gems #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd4bfcc
Wrap SassC/Sass gems
landongrindheim Sep 4, 2019
2c50e26
Correct Rubocop violations
landongrindheim Sep 4, 2019
d7e0206
Remove support for Sass
landongrindheim Sep 11, 2019
03e6364
Wrap Less engine (Tilt) for consistency
landongrindheim Sep 11, 2019
c340c57
Return empty array when there are no dependencies
landongrindheim Sep 11, 2019
bfb025b
Back out Sass/Less engine changes
landongrindheim Sep 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/hanami/assets/compilers/sass.rb
View file
Open in desktop
Expand Up @@ -16,6 +16,13 @@ def self.eligible?(name)
name.to_s =~ EXTENSIONS
end

# @since 1.3.3
# @api private
def initialize(*)
super
require 'sassc'
end

private

# @since 0.3.0
Expand All @@ -33,6 +40,8 @@ def renderer
# @api private
def dependencies
renderer.dependencies.map(&:filename)
rescue source::NotRenderedError
[]
end

# @since 1.3.2
Expand Down
4 changes: 2 additions & 2 deletions lib/hanami/assets/compressors/sass_stylesheet.rb
View file
Open in desktop
@@ -1,5 +1,4 @@
require 'hanami/assets/compressors/stylesheet'
require 'sassc'

module Hanami
module Assets
Expand All @@ -17,7 +16,8 @@ class SassStylesheet < Stylesheet
# @since 0.1.0
# @api private
def initialize
@compressor = SassC::Engine
require 'sassc'
@compressor = ::SassC::Engine
end

# @since 0.1.0
Expand Down