Run multiple assets processes #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timriley
force-pushed
the
multiple-assets-processes
branch
from
62836b8
to
0e763e5
Compare
This was referenced Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build upon hanami/assets-js#20 and update the
assets compileandassets watchcommands to fork a child process per slice and run a separate assets command per each.Provide appropriate
--pathand--destflags for each of these commands, allowing each slice's assets to be compiled separately and generated into distinct directories (public/assets/for the app, andpublic/assets/[slice_name]/for slices).Supports per-slice assets config, by running a slice's own
config/assets.js, if present, otherwise falling back to the app'sconfig/assets.js.Finally, incorporates hanami/assets#138, using the new
node_commandsetting to invoke node when running theconfig/assets.jscommand.