Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertise Bundler & Hanami installation while running hanami new #54

Merged
merged 3 commits into from
Oct 23, 2022

Conversation

jodosha
Copy link
Member

@jodosha jodosha commented Oct 23, 2022

Enhancement

Advertise Bundler & Hanami installation while running hanami new

⚡ hanami new bookshelf
-> Within bookshelf/
⚡ hanami new bookshelf
Created bookshelf/
-> Within bookshelf/
Created .env
Created README.md
Created Gemfile
Created Rakefile
Created config.ru
Created config/app.rb
Created config/settings.rb
Created config/routes.rb
Created config/puma.rb
Created lib/tasks/.keep
Created lib/bookshelf/types.rb
Created app/actions/.keep
Created app/action.rb
Running Bundler install...
Running Hanami install...

👉 The last two lines are the addition of this enhancement.

Why?

Bundler, and potentially Hanami, installation can be time consuming.

Without advertising their execution, the user has the impression that hanami new is stuck at the last file creation (e.g. Created app/action.rb).

@jodosha jodosha added the enhancement New feature or request label Oct 23, 2022
@jodosha jodosha added this to the v2.0.0 milestone Oct 23, 2022
@jodosha jodosha requested review from solnic and cllns October 23, 2022 11:22
@jodosha jodosha self-assigned this Oct 23, 2022
@jodosha jodosha merged commit c93a227 into main Oct 23, 2022
@jodosha jodosha deleted the hanami-new-print-bundler-hanami-install branch October 23, 2022 13:18
@cllns
Copy link
Member

cllns commented Oct 24, 2022

Thanks @jodosha. For reference, this is improving the UX from my work in #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants