-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Configuration#modules into #prepare #57
Comments
@jodosha can you please explain the motive behind this decision? |
@joneslee85 IMO that initial name was wrong: we don't define the modules to include, but we pass a code block. That block is evaluated when In code terms, if it was something like the following code, it could've had a sense to name it configure do
modules Lotus::Action::Session, Lotus::Action::Cookies
end But with the current implementation we can do something more than listing modules: configure do
prepare do
include Lotus::Action::Sessions
use SomeMiddleware
before :do_something
end
end What do you think? |
@jodosha i see. I am cool with the idea of passing a code block but I am wondering how you extend/override? |
Please remember to update the README too.
The text was updated successfully, but these errors were encountered: