Small Typos in Associations Guide #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodosha
reviewed
Jan 2, 2017
| @@ -122,7 +122,7 @@ class AuthorRepository < Hanami::Repository | |||
| end | |||
|
|
|||
| def find_with_books(id) | |||
| aggregate(:books).where(authors__id: id).as(Author).one | |||
| aggregate(:books).where(author_id: id).as(Author).one | |||
There was a problem hiding this comment.
This is Sequel syntax, it's correct with double underscore. 😉
|
@christopherciufo Hi and thanks for this PR.
Sorry, but I don't understand this question. Can you please tell us an example of what you are trying to achieve? Thanks! 😄 |
|
@jodosha maybe is the line you commented. @christopherciufo thanks for your PR, could you fix what @jodosha said? Thanks! |
|
Sorry all for the confusion. This very tiny PR is ready to go haha 👍 |
|
thanks and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small typos I found while reading through the docs for the first time
As I am very new to Hanami, can someone confirm that the
whereclause correction makes sense? Thanks.