Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for repository last and second methods #281

Merged
merged 2 commits into from Oct 23, 2017
Merged

Conversation

davydovanton
Copy link
Member

Reference to hanami/model#380

/cc @hanami/documentation @cllns @jodosha

@cllns
Copy link
Member

cllns commented Feb 23, 2017

Thanks for remembering to do this @davydovanton <3

I committed some changes to this branch. I think they help explain the rationale behind recommending one vs first.

But I don't think this should be merged now:

  • someone else should check my changes for accuracy, and
  • we should add note about how first and last are different (returning Hash vs entity). I feel like that was the impetus behind this change, and we don't directly address it. Instead, we tell people how to avoid it.

@davydovanton
Copy link
Member Author

@cllns
raw

@AlfonsoUceda
Copy link
Contributor

@cllns @davydovanton good work ;)

The documentation is fine for me but as @cllns said:

we should add note about how first and last are different (returning Hash vs entity). I feel like that was the impetus behind this change, and we don't directly address it. Instead, we tell people how to avoid it.

This would be perfect :)

@AlfonsoUceda
Copy link
Contributor

@cllns @davydovanton is there a chance to finish this?

@jodosha jodosha merged commit 2395097 into build Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants