-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update community page #307
Conversation
@davydovanton I like it, @cllns could your add your magical touch of your english skills? :P |
@davydovanton can you take a look at the changes I pushed and let me know what you think? I renamed the section headers to what each one was, rather than the use for them. I think you intentionally had it that way, so let me know if you prefer that. I'm not sure we should list the forum as the first go-to place for questions. It's not used very much. I think we want it to be used more, but Gitter is currently better for questions. Not sure how to handle that :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cllns awesome work 👏
@cllns teamwork 👍 |
source/community.html.erb
Outdated
<p>Help is welcome and much appreciated, whether you are an experienced developer or just looking for sending your first pull request. Please check the open tikets.</p> | ||
<a href="https://github.com/search?utf8=%E2%9C%93&q=user%3Ahanami+state%3Aopen+label%3Aeasy+label%3Ahelp-wanted&type=Issues&ref=searchresults" target="_blank">Open Tickets</a> | ||
|
||
<h2 class="page-header">Images</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe s/Images/Logo ?
source/community.html.erb
Outdated
<a href="https://github.com/search?utf8=%E2%9C%93&q=user%3Ahanami+state%3Aopen+label%3Aeasy+label%3Ahelp-wanted&type=Issues&ref=searchresults" target="_blank">Open Tickets</a> | ||
|
||
<h2 class="page-header">Images</h2> | ||
<p>Hanami is fully open source. That's why you can download our logo in different formats:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rephrase it with:
"Hanami logo it's © Luca Guidi, but you can download and use it for non-commercial scopes."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look good to me, but before to merge I want to hear @hanami/community opinion first on these changes.
addressed your concerns, @jodosha :) |
Quoting @davydovanton
We can't copy and paste somebody's else work. I'd like to update the texts before to merge/publish this. |
@davydovanton Yes, sure, I will have a look tonight. |
@davydovanton @jodosha I'll have a look at it tomorrow 👍 |
@davydovanton @cllns @jodosha @oana-sipos Hey guys, I think this community page is a great idea. Please check my last commit. I rewrote the text that was taken from the crystal community page. I also changed the order a bit. Feel free to give feedback, I can also change it back 😃 Questions
|
@marionschleifer the texts look good to me, thanks for taking care of this! I really like the idea of having talks about Hanami somewhere on the website. |
@marionschleifer text is excellent 👏 About question:
|
@davydovanton @jodosha @oana-sipos @cllns Hey guys, I updated the community page with conference talks. Please have a look and get back to me, if I should change anything 😃 |
Awesome. All looks perfect 👍 |
@marionschleifer @davydovanton @cllns you did a great job! 👏 💚 🌸 Shall we link Team and Contributors too? |
Looks great 👏 |
<h2 class="page-header">Mailing List</h2> | ||
<p>To stay updated with the latest releases, to receive code examples, implementation details and announcements, please consider to subscribe to the <a href="/mailing-list">Hanami mailing list</a>.</p> | ||
|
||
<h2 class="page-header">Conference Talks about Hanami</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO this section could be in a separate section. What do you think about a separate section for Learning
?
folks, let's merge this great changes? |
@davydovanton From my side, it can be merged 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you all.
thanks for review folks 👍 |
Hey,
I start working on new community page (#301). Here you can find base PR with a new structure.
New community page screenshot
What the next
I think we need to create some issues with:
/cc @hanami/core