Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update community page #307

Merged
merged 7 commits into from
Apr 19, 2017
Merged

Update community page #307

merged 7 commits into from
Apr 19, 2017

Conversation

davydovanton
Copy link
Member

Hey,
I start working on new community page (#301). Here you can find base PR with a new structure.

New community page screenshot

What the next

I think we need to create some issues with:

  • new icons for each link
  • update texts (I used texts from crystal page)

/cc @hanami/core

@AlfonsoUceda
Copy link
Contributor

@davydovanton I like it, @cllns could your add your magical touch of your english skills? :P

@cllns
Copy link
Member

cllns commented Apr 4, 2017

@davydovanton can you take a look at the changes I pushed and let me know what you think? I renamed the section headers to what each one was, rather than the use for them. I think you intentionally had it that way, so let me know if you prefer that.

I'm not sure we should list the forum as the first go-to place for questions. It's not used very much. I think we want it to be used more, but Gitter is currently better for questions. Not sure how to handle that :)

Copy link
Member Author

@davydovanton davydovanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cllns awesome work 👏

@davydovanton
Copy link
Member Author

@cllns teamwork 👍
gif

<p>Help is welcome and much appreciated, whether you are an experienced developer or just looking for sending your first pull request. Please check the open tikets.</p>
<a href="https://github.com/search?utf8=%E2%9C%93&q=user%3Ahanami+state%3Aopen+label%3Aeasy+label%3Ahelp-wanted&type=Issues&ref=searchresults" target="_blank">Open Tickets</a>

<h2 class="page-header">Images</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe s/Images/Logo ?

<a href="https://github.com/search?utf8=%E2%9C%93&q=user%3Ahanami+state%3Aopen+label%3Aeasy+label%3Ahelp-wanted&type=Issues&ref=searchresults" target="_blank">Open Tickets</a>

<h2 class="page-header">Images</h2>
<p>Hanami is fully open source. That's why you can download our logo in different formats:</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rephrase it with:

"Hanami logo it's © Luca Guidi, but you can download and use it for non-commercial scopes."

Copy link
Member

@jodosha jodosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look good to me, but before to merge I want to hear @hanami/community opinion first on these changes.

@cllns
Copy link
Member

cllns commented Apr 5, 2017

addressed your concerns, @jodosha :)

@jodosha
Copy link
Member

jodosha commented Apr 6, 2017

Quoting @davydovanton

update texts (I used texts from crystal page)

We can't copy and paste somebody's else work. I'd like to update the texts before to merge/publish this.

@davydovanton
Copy link
Member Author

@jodosha good point 👍
@cllns @hanami/community could you help me with it? 😊

@oana-sipos
Copy link
Collaborator

@davydovanton Yes, sure, I will have a look tonight.

@marionschleifer
Copy link
Member

@davydovanton @jodosha I'll have a look at it tomorrow 👍

@marionschleifer
Copy link
Member

marionschleifer commented Apr 7, 2017

@davydovanton @cllns @jodosha @oana-sipos

Hey guys, I think this community page is a great idea. Please check my last commit. I rewrote the text that was taken from the crystal community page. I also changed the order a bit. Feel free to give feedback, I can also change it back 😃

Questions

  • Do we want another section where we list talks about Hanami at conferences?
  • Do we want to include a picture that represents the community spirit?

@oana-sipos
Copy link
Collaborator

@marionschleifer the texts look good to me, thanks for taking care of this! I really like the idea of having talks about Hanami somewhere on the website.

@davydovanton
Copy link
Member Author

@marionschleifer text is excellent 👏

About question:

  1. Great idea 👍
  2. For me, "cosmetic" images will overload this page. WDYT?

@marionschleifer
Copy link
Member

@davydovanton @jodosha @oana-sipos @cllns

Hey guys, I updated the community page with conference talks.

Please have a look and get back to me, if I should change anything 😃

@davydovanton
Copy link
Member Author

Awesome. All looks perfect 👍
@cllns @marionschleifer thanks for you work with text 👏

teamwork
tumblr_mwu054zuzw1slfdfko1_400

@jodosha
Copy link
Member

jodosha commented Apr 12, 2017

I added the Twitter hashtag:

screen shot 2017-04-12 at 15 43 39

Feel free to revert the commit if you think it isn't a good idea.

@jodosha
Copy link
Member

jodosha commented Apr 12, 2017

@marionschleifer @davydovanton @cllns you did a great job! 👏 💚 🌸

Shall we link Team and Contributors too?

@davydovanton
Copy link
Member Author

Looks great 👏
I think the contributions link is unnecessary here

<h2 class="page-header">Mailing List</h2>
<p>To stay updated with the latest releases, to receive code examples, implementation details and announcements, please consider to subscribe to the <a href="/mailing-list">Hanami mailing list</a>.</p>

<h2 class="page-header">Conference Talks about Hanami</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this section could be in a separate section. What do you think about a separate section for Learning?

@davydovanton
Copy link
Member Author

folks, let's merge this great changes?

@marionschleifer
Copy link
Member

@davydovanton From my side, it can be merged 👍

Copy link
Member

@jodosha jodosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you all.

@davydovanton
Copy link
Member Author

thanks for review folks 👍

@davydovanton davydovanton merged commit 156db57 into build Apr 19, 2017
@davydovanton davydovanton deleted the new-community branch April 19, 2017 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants