-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Change Getting Started to use RSpec #429
Closed
Closed
Commits on Jan 10, 2018
-
Change Getting Started to use RSpec
For now, using `--test=rspec`, but we anticipate to change RSpec to be the default testing framework for Hanami. MiniTest is simpler, but it's less familiar to most people. Additionally, when this was created, Hanami itself used MiniTest. We've since switched over to RSpec, since we needed some of its more powerful features (and it's what most of use most of the time).
Configuration menu - View commit details
-
Copy full SHA for c6d48b1 - Browse repository at this point
Copy the full SHA c6d48b1View commit details
Commits on Jan 23, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 4fc303f - Browse repository at this point
Copy the full SHA 4fc303fView commit details -
Rename "Hanami Architecture" to "Hanami's Architecture", since that's more natural. Also, explain more about the project structure and what `apps` are.
Configuration menu - View commit details
-
Copy full SHA for d4a42d8 - Browse repository at this point
Copy the full SHA d4a42d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64959d8 - Browse repository at this point
Copy the full SHA 64959d8View commit details -
Fix the test syntax to use RSpec's output. Also clarify some other language.
Configuration menu - View commit details
-
Copy full SHA for fb1a45b - Browse repository at this point
Copy the full SHA fb1a45bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f9845e - Browse repository at this point
Copy the full SHA 1f9845eView commit details -
Configuration menu - View commit details
-
Copy full SHA for df10089 - Browse repository at this point
Copy the full SHA df10089View commit details -
Specifically, refer to them as "Layout templates" instead of just "Layouts", since the latter are a Ruby class in the app.
Configuration menu - View commit details
-
Copy full SHA for ab9cdcf - Browse repository at this point
Copy the full SHA ab9cdcfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00b69b8 - Browse repository at this point
Copy the full SHA 00b69b8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.