Allow to configure sessions

[jodosha]

A Lotus application should provide an API to enable sessions and to allow developers to set options for it. This should take advantage of the middleware configuration (#40).

Proposal:

module Bookshelf
  class Application < ::Lotus::Application
    configure do
      sessions true

      middleware.use Rack::Session::Redis,
        domain: 'foo.com',
        expire_after: 2592000
    end
  end
end

Please note that sessions true should enable sessions, by including Lotus::Action::Sessions into Bookshelf::Action taking advantage of Lotus::Controller::Configuration#modules.

The ideal place where this should happen is at the load time.

Alternative proposal:

module Bookshelf
  class Application < ::Lotus::Application
    configure do
      sessions :redis,
        domain: 'foo.com',
        expire_after: 2592000
    end
  end
end

This should:

1. Enable sessions with the same mechanisms above
2. Lookup for a Rack::Session::Redis middleware and add it with middleware.use

This is alternative is nicer, because it hides the internal requirements of the framework (see sessions true above). On the other hand, we're introducing a convention: :redis => Rack::Session::Redis. I'd make #sessions to accept also a class (name). Example sessions MySessionStore and/or sessions 'MySessionStore'.

[mistersourcerer]

Hy @jodosha, can you provide some more context on what do you need here?

[jodosha]

@ricardovaleriano I've updated the description of this ticket with a design proposal.

[simi]

@jodosha what would session true do? For example in sinatra, similar code is adding Rack::Session::Cookie with given params (for example secret key) to middleware stack.

Now it looks like two session middlewares will be used at the same time for your example.

[jodosha]

@simi from the description:

Please note that sessions true should enable sessions, by including Lotus::Action::Sessions into Bookshelf::Action taking advantage of Lotus::Controller::Configuration#modules.

I'm gonna rethink the proposal, the actual is verbose because of the framework internals.

[simi]

Damn, I should try to read better.

Anyway, session true is providing only session method for Lotus::Action now. You need to use some session storage middleware always. Can you confirm this?

[jodosha]

@simi I confirm. please have a look at the updated proposal.

[mistersourcerer]

Nice @jodosha, thank you for the clarification.

[michalmuskala]

Is anybody doing something about this issue? If not I'd like to help with this.

[gotjosh]

It's assigned to me but I have plans to work on it over the weekend or by the end of the week. If you'd like to take it for spin and you'll have it completed sooner then I don't mind at all.