Allow session configuation #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add #sessions Lotus::Configuration, used to enable and configure sessions * add Lotus::Config::Sessions responsible for sessions configuration and sessions middleware construction * move assets middleware construction to Lotus::Config::Assets to be consistient with sessions * include Lotus::Action::Session to controllers if sessions are enabled * defer loading default middleware stack (assets and sessions) to load time, and not middleware stack initialization. * change Lotus::Config::Middleware tests to account for the configuration loading that happens at application initialization, test for disabled assets was false positive in previous setup Closes #2
|
@michalmuskala Thanks for this PR. I'll dig into the code at the beginning of the next week, as I'm traveling right now. Let's discuss later on. |
| @@ -27,6 +27,10 @@ def enabled? | |||
| !@path.nil? | |||
| end | |||
|
|
|||
| def middleware | |||
There was a problem hiding this comment.
I'd like to keep the Rack concern out of this. This object abstracts some file system knowledge, better to keep it simple. Middleware should be the right place for this.
* Move assets and sessions middleware configuration to Config::Middleware * Move default session options to Config::Sessions
|
@michalmuskala I've finally merged this. It will be part of the upcoming 0.2.0. Thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sessions middleware construction
consistient with sessions
and not middleware stack initialization.
configuration loading that happens at application initialization, test
for disabled assets was false positive in previous setup
Closes #2