New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`force_ssl` is deprecated but still generated into new projects #971

Closed
graywolf opened this Issue Nov 21, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@graywolf
Copy link
Contributor

graywolf commented Nov 21, 2018

According to https://guides.hanamirb.org/upgrade-notes/v130/ , force_ssl is deprecated but when I started new project using hanami 1.3, I still see that in application.rb.

$ cat apps/*/application.rb | grep force_ssl
      # force_ssl true

packrat386 added a commit to packrat386/hanami that referenced this issue Dec 1, 2018

Remove force_ssl from new app templates
The use of this configuration is deprecated as of v1.3.0

Closes hanami#971

@jodosha jodosha added this to the v1.3.1 milestone Dec 11, 2018

packrat386 added a commit to packrat386/hanami that referenced this issue Dec 16, 2018

Remove force_ssl from new app templates
The use of this configuration is deprecated as of v1.3.0

Closes hanami#971

@jodosha jodosha closed this in #974 Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment