Fix scope of used middleware in slice routes #1047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timriley
commented
Apr 24, 2020
Comment on lines
+43
to
+44
| # With this here, it ends up applying to _all_ routes, including admin | ||
| use TestApp::Middleware, :main |
There was a problem hiding this comment.
One aspect of the problem: this shouldn't run on admin routes
timriley
commented
Apr 24, 2020
Comment on lines
+50
to
+51
| # With this here, all admin routes return 404 | ||
| use TestApp::Middleware, :admin |
There was a problem hiding this comment.
And obviously this shouldn't make all the admin routes become 404s!
There was a problem hiding this comment.
I encountered this recently. admin routes become nested once more.
/admin/admin=> admin's home#show/admin/admin/test=> admin's test#show
And main routes are nested in too, causing
/admin=> main's home#show
I found it's because the Hanami::Application::Routing::Middleware::Stack creates a map for '/admin' but run the whole app under it.
|
Closing this as it's outdated and I pushed a branch with the updated repro spec here https://github.com/hanami/hanami/tree/fix-slice-middlewares |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jodosha Here's a failing spec demonstrating a couple of different problems with middleware being
used inside slice routes.I've started poking around but haven't yet found a fix. I'd imagine you might be a lot quicker with this given you recently built all of this – would you mind having a look?