Ensure prepare_container works as expected in App #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timriley
commented
Jul 17, 2022
| @@ -219,6 +219,7 @@ def prepare_slice | |||
|
|
|||
| prepare_all | |||
|
|
|||
| instance_exec(container, &@prepare_container_block) if @prepare_container_block | |||
There was a problem hiding this comment.
This is basically the change, moving this instance_exec to a different spot. Everything else in this PR is ensuring we now have appropriate test coverage for this behaviour :)
timriley
force-pushed
the
consistent-prepare-container-in-app-and-slice
branch
2 times, most recently
from
75da435
to
ad6c18f
Compare
We want to ensure that the `prepare_container` block is run at the _last moment_ before the container is marked as `configured!`. With this change, this is now true for both `App` and `Slice`. Before this change, the `prepare_container` block for `App` was being run before the app-specific configuration was applied.
timriley
force-pushed
the
consistent-prepare-container-in-app-and-slice
branch
from
ad6c18f
to
7defc12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to ensure that the
prepare_containerblock is run at the last moment before the container is marked asconfigured!. With this change, this is now true for bothAppandSlice.Before this change, the
prepare_containerblock forAppwas being run before the app-specific configuration was applied.