Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update asset helpers to accept
Hanami::Assets::Asset
instances and use the URL from those, instead of trying to look up the asset from theassets
in the view context.See
spec/integration/assets/cross_slice_assets_helpers_spec.rb
(added in this PR) for a full demonstration, but in short, using assets from across slices involves:(1) Importing the
assets
object from one slice to another:(2) Making the imported assets component available in the view context:
(3) Using the asset objects directly with the assets helpers:
The recommended way to use assets is in full isolation, which is why I don't think we need to further streamline the steps above. But doing this shows how it is possible and should allow people to achieve cross-slice asset usage if their situation requires it.