Global serve static assets #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodosha
force-pushed
the
global-serve-static-assets
branch
from
3ff42fb
to
2f387d2
Compare
…S="true" This enables Lotus::Static to be mounted in Rack middleware and to serve static assets by default in development and test environments.
This allows to suppor the following scenario:
module Web
class Application < Lotus::Application
configure do
assets do
# general assets configuration
end
end
configure :production do
assets do
# production specific assets configuration
end
end
end
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lotus Static
Introduce
Lotus::Static, it's a global middleware for static assets. It's mounted inside:Lotus::Containerfor Container architectureSince v0.6, Lotus applications will use
public/assetsas target destination for static assets. This middleware will serve them from that directory, or lazy precompile and serve them if they're missing.This is mounted by default in development/test environments, but disabled in production. It's slower than Nginx and it shouldn't be used in production for high performance applications.
To let Lotus to mount it, we have a new env var:
SERVE_STATIC_ASSETSin.envfiles.Breaking Change
This PR removes
serve_staticassets fromLotus::Configuration.