Add reload! to lotus console
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| opts[:applications] = 'test/fixtures/microservices/config/applications' | ||
| console.stub(:engine, @engine) { console.start } | ||
|
|
||
| @main.verify |
|
@davidcelis Thanks for this PR. Because we don't have a proper web reloading process (see #24 ), I'm wondering how this works, and if it does, do you think it may be a viable solution for the other features? EDIT: I'm not wondering how this works w/ Ruby, but if this simple trick resolves all the complexity of Lotus.. ✨ 💯 ✨ |
|
I think that Rack::Reloader is still gonna be the best bet for reloading the web app as code changes in development, since |
This patch adds a `reload!` method during `lotus console` sessions, much like what is available during a `rails console` session. `reload!` will simply call `Kernel.exec $0` to re-execute the running process after outputting a message that it is doing so. Signed-off-by: David Celis <me@davidcel.is>
|
@davidcelis Alright, merging this for now. Thanks! |
jodosha
added a commit
that referenced
this pull request
Jul 11, 2014
Add `reload!` to `lotus console`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a
reload!method duringlotus consolesessions, muchlike what is available during a
rails consolesession.reload!willsimply call
Kernel.exec $0to re-execute the running process afteroutputting a message that it is doing so.
Signed-off-by: David Celis me@davidcel.is