Allow configuration of Cookies. #51
Conversation
| # called without, it will return the already set value, or the default. | ||
| # | ||
| # @overload cookies(value) | ||
| # Instructs lotus#load_frameworks! to inject Lotus::Action:Cookies. |
There was a problem hiding this comment.
Documentation should be high level, if we change the loader internals we should change this line too.
What do you think about: Enable cookies (disabled by default)?
|
Thank you very much for the feedback @jodosha, will start tidying up immediately. Do you want me to amend the mistakes to keep the history clean or want me to put a commit on top of it? |
| # Gets the boolean value or returns false if it's not set. | ||
| # @return [Boolean] | ||
| # | ||
| # @since 0.1.0 |
|
@gotjosh Thank you for your first PR. It looks good. Before to merge it:
Thanks |
|
@gotjosh Please add more commits, don't worry about the clean history. |
|
@jodosha Could you point me in the right direction when it comes to where you'd like me to add the integration tests? From here, it's uncertain whenever you want me to add in middleware or any of the other apps... 😁 |
|
@gotjosh Please have a look at You should create a tiny app like |
Allow the `Lotus#configuration` to inject the `Lotus::Action::Cookies` module in your application’s controller. When the application is loading the framework, `Lotus::Loader.load_frameworks!` will inject the before mentioned module if the configuration is set. Closes #1. Signed-off-by: Josue Abreu josh@pixelpt.com
- Documentation should be high level. - Replace boolean with TrueClass & FalseClass. - Removing redundant overloads.
| @@ -410,6 +410,10 @@ module Bookshelf | |||
| # | |||
| routes 'config/routes' | |||
|
|
|||
| # The mapping set (optional) (alternative usage) | |||
There was a problem hiding this comment.
This is out of scope here, can you please remove it?
|
@gotjosh This looks good 👍 Can you please remove that mapping documentation so that we can merge it? Thanks. |
|
@gotjosh I've also tried that |
This reverts commit 14f40de.
|
@jodosha Everything should be good to go! |
Allow configuration of Cookies.
|
@gotjosh Thanks for your work! 👍 |
Allow the
Lotus#configurationto inject theLotus::Action::Cookiesmodule in your application’s controller.
When the application is loading the framework,
Lotus::Loader.load_frameworks!will inject the before mentionedmodule if the configuration is set.
Closes #1.
Signed-off-by: Josue Abreu josh@pixelpt.com