Support --template for hanami new #515
Conversation
|
// cc @jodosha |
| SUPPORTED_ENGINES = %w(erb slim haml).freeze | ||
| DEFAULT_ENGINE = 'erb'.freeze | ||
|
|
||
| attr_reader :engine |
There was a problem hiding this comment.
what do you think about name instead of engine? To me, template_engine.name is more meaningful than template_engine.engine
|
Have we cover haml and erb engine in our tests? |
|
👍🏼 |
jodosha
changed the title
| head | ||
| title | ||
| | <%= config[:classified_app_name] %> | ||
| - = favicon |
There was a problem hiding this comment.
@aderyabin This dash here causes an exception. Please have a look at the attached screenshot. Can you confirm the problem?
|
@aderyabin It works fine except for an error caused by the generated Slim layout template. |
|
@jodosha I fixed it, but the slim template is already in Workflow: I guess it should not work. |
|
@aderyabin Please fix it as well. Thank you very much. /cc @davydovanton @joneslee85 |
|
@jodosha Fixed in the PR. |
|
@aderyabin Merged in master. Thank you very much 👍 |
Closes #507