Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing typos in README #6

Merged
merged 1 commit into from Jun 24, 2014
Merged

Fixing typos in README #6

merged 1 commit into from Jun 24, 2014

Conversation

jeremyf
Copy link
Contributor

@jeremyf jeremyf commented Jun 23, 2014

[skip ci]

@jodosha
Copy link
Member

jodosha commented Jun 24, 2014

@jeremyf your help is always appreciated! 👍

jodosha added a commit that referenced this pull request Jun 24, 2014
@jodosha
Merge pull request #6 from jeremyf/wordsmithing-readme-typos
84074a3 
Fixing typos in README
@jodosha jodosha merged commit 84074a3 into hanami:master Jun 24, 2014
@jodosha jodosha mentioned this pull request Jun 24, 2014
Closed
@jeremyf jeremyf deleted the wordsmithing-readme-typos branch June 24, 2014 12:35
@jeremyf
Copy link
Contributor Author

jeremyf commented Jun 24, 2014

Now I just want to use Lotus.

@jodosha jodosha mentioned this pull request Jun 24, 2014
Closed
lengarvey added a commit to lengarvey/lotus that referenced this pull request Jun 24, 2014
@lengarvey
Removing unused setup code from Lotus::Loader test
43ea0bb 
The test fixture setup and `@loader` assignment aren't required in `loader_test.rb` in order for the test to pass. I suspect this is because the loading occurs on `Lotus::Application.new` but at some stage a different thing was planned.

This test is also strange because it claims to test `Lotus::Loader#load!` but never directly calls that method. It seems marginally related to the original `OneLine` application before hanami#6 was merged where it looked like:

```ruby
require 'lotus'

module OneFile
  class Application < Lotus::Application
    configure do
      routes do
        get '/', to: 'home#index'
      end
    end
  end
end

# OneFile::Application.new
# we could uncomment this to force framework duplication

module OneFile
  module Controllers
    module Home
      include OneFile::Controller

      action 'Index' do
        def call(params)
        end
      end
    end
  end

  module Views
    module Home
      class Index
        include OneFile::View

        def render
          'Hello'
        end
      end
    end
  end
end
```

This fails because at class declaration time the application has not been loaded and the framework hasn't been duped into the extra modules. Instead we could force this duplication to occur by running `OneFile::Application.new` before declaring our `Controller` and `View` modules but this then requires two instantiations of our application. Once here and once in `config.ru`
@lengarvey lengarvey mentioned this pull request Jun 24, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeremyf @jodosha