Use poltergeist for all platforms #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
to me it's ok! it works and we can get rid of capybara-webkit (QT!!!) cc @jodosha |
|
@cllns Thank you very much for this PR. This facilitates newcomers' life. 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux and JRuby:
poltergeistdepends onphantomjs, which is 16+ MB.Everything else:
capybara-webkitdepends onQT, which is 700+ MB.Using two different libraries based on platform could cause problems down the road if the drivers behave differently.
Can we just use poltergeist for all platforms?
@jodosha What do we need these for? Do we have feature tests that need JS? I'd prefer using
Rack::Test(no dependencies) if possible!