Generate empty lib/<project-name>.rb file
#762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cllns
reviewed
Mar 30, 2017
| @@ -44,7 +44,6 @@ | |||
| # lib/<project>.rb | |||
| # | |||
| expect("lib/#{project}.rb").to have_file_content <<-END | |||
There was a problem hiding this comment.
can this be changed to just "" (or "\n"?) instead of using the HEREDOC?
Also, do we need this file at all, if it's blank? If so, could we put a comment in here saying something like
# This file is intentionally blank.There was a problem hiding this comment.
@cllns Yeah, I'm gonna switch from HEREDOC to simpler string representation.
I was thinking to define a blank module like:
module Bookshelf
end
There was a problem hiding this comment.
Good idea with the empty module 👍
Maybe we also add the comment with this PR? I'm sure that some developers will have questions about this module in future.
|
Just to confirm. This fixes #758 for me :D |
Example:
$ hanami new cool_project
$ cd cool_project
$ cat lib/cool_project.rb
module CoolProject
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a suggested solution to fix #758
/cc @ixti and @hanami/core for review.