Fixed errors in README related to OneFile. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that `OneFile::Controllers` didn't exist yet and we were trying to create `OneFile::Controllers::Home`. We had the same problem with `OneFile::Views` and `OneFile::Views::Home` We also want to include `Lotus::Controller` instead of `OneFile::Controller` and `Lotus::View` instead of `OneFile::View`.
|
Makes sense. Flat namespace declarations suck 😣 |
|
Yes, I commonly see problems when they're used. |
|
@parndt Thank you, merging 👍 |
jodosha
added a commit
that referenced
this pull request
Jun 24, 2014
Fixed errors in README related to OneFile.
kimh
pushed a commit
to kimh/lotus
that referenced
this pull request
Jul 9, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that
OneFile::Controllersdidn't exist yet and we were trying to createOneFile::Controllers::Home. We had the same problem withOneFile::ViewsandOneFile::Views::HomeWe also want to include
Lotus::Controllerinstead ofOneFile::ControllerandLotus::Viewinstead ofOneFile::View.Hopefully this accurately reflects how it should be working.