[WIP] Colorize file generation #906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cllns
commented
Feb 26, 2018
| @@ -8,7 +8,7 @@ end | |||
|
|
|||
| gem 'i18n' | |||
|
|
|||
| gem 'hanami-utils', '~> 1.1', require: false, git: 'https://github.com/hanami/utils.git', branch: '1.1.x' | |||
| gem 'hanami-utils', '~> 1.1', require: false, git: 'https://github.com/hanami/utils.git', branch: 'coloured_output' | |||
There was a problem hiding this comment.
Temporary, until this branch is merged in.
| if OPERATION_COLORS.key?(operation) | ||
| _colorize_and_justify(operation) | ||
| else | ||
| operation.to_s.rjust(COLUMN_WIDTH) |
There was a problem hiding this comment.
We could just colorize other stuff to black, to get rid of this conditional.
There was a problem hiding this comment.
@cllns This assumes a black terminal background.
|
@cllns This feature is just great to have, but it comes with the cost of changing all the specs under My suggestion is to:
Snippet 1# config/environment.rb
Hanami.configure do
# ...
cli colorize: false
end |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a work-in-progress for colorizing the CLI commands:
You can see what changes will be necessary to the CLI specs. It's a lot of manual work (or could be automated) but it'll cause a lot of diff noise, and make it much harder to edit the output of the specs in the future.
We (@jodosha and I) have talked about extracting the file generation commands into
hanami/cli. If we did that, then we could test these exact CLI things, without repeating the shellcodes a bunch of times in this repo. We could even write a helper to strip the shellcodes, if we wanted.Thoughts? @jodosha @hanami/core?