Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set selected option based on entity's attribute #69

Merged
merged 4 commits into from
Jul 5, 2016
Merged

Set selected option based on entity's attribute #69

merged 4 commits into from
Jul 5, 2016

Conversation

sebastjan-hribar
Copy link
Contributor

This is the implementation for #66.

It enables to set the selected option if one of the option values matches the passed entity's attribute:

select :author, authors, selected: book.id

@coveralls
Copy link

coveralls commented Jun 27, 2016 •
edited

Coverage Status

Coverage increased (+0.02%) to 95.877% when pulling 8c6f53a on sebastjan-hribar:set_selected_option into b534567 on hanami:master.

@runlevel5 runlevel5 added this to the v0.4.0 milestone Jul 1, 2016
@jodosha
Copy link
Member

jodosha commented Jul 5, 2016

@sebastjan-hribar This looks good. Thanks!

@jodosha jodosha self-assigned this Jul 5, 2016
@jodosha jodosha merged commit bdb3369 into hanami:master Jul 5, 2016
@jodosha jodosha mentioned this pull request Jul 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jodosha jodosha

Labels
enhancement
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sebastjan-hribar @coveralls @jodosha @runlevel5