Fix send nil value when creating an entity #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lotus/core-team @7even @luishurtado |
| coercer.to_record(entity).must_equal(name: 'Daenerys Targaryen') | ||
| end | ||
|
|
||
| it 'forces nil values' do |
There was a problem hiding this comment.
i am confused with the description, should it be it ignores nil values on creating?
There was a problem hiding this comment.
IMO this describe block is when you create new record, we test two cases, new entity without forcing an attribute to nil and another case forcing a nil attribute.
to_record method translate the entity to a format compatible with the database, then nil attributes shouldn't be sent when are creating a entity, but in this case you don't persirst an entity, only we are testing to_record method getting the correct values
runlevel5
pushed a commit
that referenced
this pull request
Mar 15, 2015
Fix send nil value when creating an entity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is @jodosha 's work, He told me finish the PR:
reference #155 #156