Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure MySQL migrator to create/drop databases with dash in name #383

Merged
merged 1 commit into from Feb 28, 2017
Merged

Ensure MySQL migrator to create/drop databases with dash in name #383

merged 1 commit into from Feb 28, 2017

Conversation

jodosha
Copy link
Member

@jodosha jodosha commented Feb 27, 2017

Closes #381

@jodosha jodosha added the fix label Feb 27, 2017
@jodosha jodosha added this to the v1.0.0.beta2 milestone Feb 27, 2017
@jodosha jodosha self-assigned this Feb 27, 2017
@jodosha jodosha mentioned this pull request Feb 27, 2017
Closed
AlfonsoUceda
AlfonsoUceda approved these changes Feb 27, 2017
View reviewed changes
Copy link
Contributor

@AlfonsoUceda AlfonsoUceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jodosha jodosha merged commit 4218b5b into master Feb 28, 2017
@jodosha jodosha deleted the fix/mysql-migrator-create-and-drop-db-with-dash-in-name branch February 28, 2017 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlfonsoUceda AlfonsoUceda AlfonsoUceda approved these changes

@mereghost mereghost Awaiting requested review from mereghost

@TiteiKo TiteiKo Awaiting requested review from TiteiKo

@cllns cllns Awaiting requested review from cllns

Assignees

@jodosha jodosha

Labels
fix
Projects
None yet
Milestone
v1.0.0.beta2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jodosha @AlfonsoUceda