added expressions to where condition #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 28, 2014 22:19
Sequel already has an option to define you condition in a code block,
like this:
```ruby
UserRepository.where{ age > 31 }
```
ghost
changed the title
ghost
changed the title
ghost
changed the title
ghost
changed the title
| # # => SELECT * FROM `articles` WHERE (`publish_at` > DATE('2014-07-29')) | ||
| def where(condition=nil, &blk) | ||
| condition or blk or raise ArgumentError.new("You need to specify an condition.") | ||
| condition = blk unless condition |
There was a problem hiding this comment.
What if we avoid this line and do:
def where(condition=nil, &blk)
condition = condition or blk or raise ArgumentError.new('You need to specify an condition.')
conditions.push([:where, condition])
end
|
@coenert Thanks for this PR, it looks good. |
|
@jodosha thanks! i also implemented the feature for |
|
@coenert that looks great! Can you please add some extra examples to all the three methods? Thanks. |
|
@coenert Looks good, merging! 👍 |
jodosha
added a commit
that referenced
this pull request
Jul 30, 2014
added expressions to where condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42