Remove #find_book from (has_many) AuthorRepository #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per hanami#550, #one is not implemented on on HasMany.
This was referenced Oct 2, 2019
|
Closing this to clear it from my GitHub dashboard. Feel free to re-open if you're interested in using it to address issue #550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #550, #one is not implemented on on HasMany.
Note: This is one of two solutions to the linked issue, the other being #553. If either is accepted, the other PR should be closed.
Note: This should be closed or merged alongside hanami/guides#52.
Closes #550