Skip to content

Commit

Permalink
replace instance methods with class methods (#177)
Browse files Browse the repository at this point in the history
  • Loading branch information
marionschleifer committed Aug 9, 2018
1 parent 2bd56aa commit 91656a2
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions benchmarks/named_routes
Expand Up @@ -28,7 +28,7 @@ Benchmark.bm(50) do |b|
app = Rack::MockRequest.new(router)

$named_routes.each do |(name, _)|
eval "#{ Hanami::Utils::String.new(name).classify } = Class.new($controller)"
eval "#{ Hanami::Utils::String.classify(name) } = Class.new($controller)"
end

b.report 'generating named routes (class endpoints)' do
Expand Down Expand Up @@ -60,7 +60,7 @@ Benchmark.bm(50) do |b|
end

$lazy.each do |(name, _)|
eval "#{ Hanami::Utils::String.new(name).classify } = Class.new($controller)"
eval "#{ Hanami::Utils::String.classify(name) } = Class.new($controller)"
end

b.report 'recognizing routes (lazy endpoints)' do
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/resource
Expand Up @@ -33,7 +33,7 @@ Benchmark.bm(50) do |b|
end

$lazy.each do |w|
eval "#{ Hanami::Utils::String.new(w).classify }Controller = Class.new($resource_controller)"
eval "#{ Hanami::Utils::String.classify(w) }Controller = Class.new($resource_controller)"
end

b.report 'recognizing routes (lazy endpoints)' do
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/resources
Expand Up @@ -40,7 +40,7 @@ Benchmark.bm(50) do |b|
end

$lazy.each do |w|
eval "#{ Hanami::Utils::String.new(w).classify }Controller = Class.new($resources_controller)"
eval "#{ Hanami::Utils::String.classify(w) }Controller = Class.new($resources_controller)"
end

b.report 'recognizing resources (lazy endpoints)' do
Expand Down
4 changes: 2 additions & 2 deletions benchmarks/routes
Expand Up @@ -28,7 +28,7 @@ Benchmark.bm(50) do |b|
app = Rack::MockRequest.new(router)

$routes.each do |route|
eval "#{ Hanami::Utils::String.new(route).classify } = Class.new($controller)"
eval "#{ Hanami::Utils::String.classify(route) } = Class.new($controller)"
end

b.report 'generating routes (class endpoints)' do
Expand Down Expand Up @@ -56,7 +56,7 @@ Benchmark.bm(50) do |b|
end

$lazy.each do |route|
eval "#{ Hanami::Utils::String.new(route).classify } = Class.new($controller)"
eval "#{ Hanami::Utils::String.classify(route) } = Class.new($controller)"
end

b.report 'recognizing routes (lazy endpoints)' do
Expand Down
4 changes: 2 additions & 2 deletions benchmarks/utils.rb
Expand Up @@ -46,11 +46,11 @@ class Index < Action; end
end

$resource.each do |w|
eval "#{ Hanami::Utils::String.new(w).classify }Controller = Class.new($resource_controller)"
eval "#{ Hanami::Utils::String.classify(w) }Controller = Class.new($resource_controller)"
end

$resources.each do |w|
eval "#{ Hanami::Utils::String.new(w).classify }Controller = Class.new($resources_controller)"
eval "#{ Hanami::Utils::String.classify(w) }Controller = Class.new($resources_controller)"
end

GC.start

0 comments on commit 91656a2

Please sign in to comment.