Add option for display header text for routes inspector

[davydovanton]

Why this is needful

This option will provide better formatting for lotus routes command, for example:

~/work/lotus_server » lotus routes
                Name Method   Path                      Action
                     POST     /api/action               Api::Controllers::Files::Action

/cc @jodosha

[jodosha]

@davydovanton This is good for clarity 👍

I'd add a line of separation between the headers and the routes.

[jodosha]

@davydovanton Can you please freeze the hash instead of the single values?

[davydovanton]

nice idea, I like this 👍

[davydovanton]

@jodosha done. If you want I can squash the commits to one

[runlevel5]

nice one

[davydovanton]

thanks @joneslee85! 😊

[jodosha]

Please squash them!

http://lucaguidi.com

On 19/dic/2015, at 21:42, Anton Davydov notifications@github.com wrote:

@jodosha done. If you want I can squash the commits to one

—
Reply to this email directly or view it on GitHub.

[davydovanton]

@jodosha done 🎉

[jodosha]

@davydovanton ✌️

[davydovanton]

Thanks! 🌟

P.S.: @jodosha I want to add search pattern (like in rails/rails#18902) what do you think it's good idea?

[jodosha]

@davydovanton No thanks 😄

When in doubt, always rely on UNIX.

[davydovanton]

[jodosha]

@davydovanton No, I wasn't trolling. Sorry if you've got that feeling. Let me better explain.

Our inspector relies on Ruby's way to print on stdout. That is compliant with UNIX pipes. So we don't have to worry how the output of our command is used by other programs like grep.

If we include that -g option in our command. We need to take care that it works similarly to grep and that the output is compliant with UNIX pipes. This increases the maintenance load for us. Think of potential bugs because we don't respect UNIX standards.

Because grep is around way before I was born, and it works great, I don't see the reason to reproduce it.

The less features you add, the less you have to worry about.

[davydovanton]

wow, thanks for explanation! I agree with you and I think the Unix way is missing in rails.

[jodosha]

A further clarification on what stated above. It's possible to make this feature fully compliant with UNIX. That -g <routename> can be used to filter the routes internally and only to print those who are matching the input.

Pseudo code:

routes = ['books', 'book']
input   = 'books'

result = routes.find_all do |route|
  route.match /#{ input }/
end

puts result

However, grep already does that.